Skip to content

A library's full path is used for addDefine #232

Description

@MoritzBrueckner

When adding a library in the Khafile like this:

project.addLibrary("D:/dev/armsdk/armory");

The hxml define looks like this:

-D D:/dev/armsdk/armory

instead of this:

-D armory

This is especially problematic when the Khafile uses absolute paths and is automatically generated like Armory does it. The flag will likely be different on different machines so there is no way to use it properly in the code.

khamake/src/Project.ts

Lines 207 to 208 in 25a96e9

addLibrary(library: string): string {
this.addDefine(library);

Link with armory3d/armory#1858 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions