Write cached zip archive to file before uploading (#26)

## Summary:
Terraform managed to trick me again. I was able to apply this from my machine, but it failed in CI. It seems the google storage upload isn't happy with pushing a zip using the `content` field. Instead, let's write the zip to file during the apply, then push that file.

Issue: INFRA-XXXX

## Test plan:
I again ran this and triple-checked that the zip was actually pushed and deployed as a cloud function. See the latest revision [here](https://console.cloud.google.com/run/detail/us-central1/check-sentry-rate-limiting/revisions?project=khan-internal-services).

Author: jwbron

Reviewers: copilot-pull-request-reviewer[bot], jwbron, csilvers, MiguelCastillo

Required Reviewers:

Approved By: csilvers

Checks: ✅ 7 checks were successful, ⏭️  2 checks have been skipped

Pull Request URL: #26

Author: jwbron

terraform/modules/scheduled-job/main.tf

@@ -56,6 +56,17 @@ data "local_sensitive_file" "function_archive_content" {
   depends_on = [data.archive_file.function_archive]
 }
 
+# Write the embedded zip content to a file
+# This recreates the zip file using the content embedded in the tfplan binary
+# This supports running an `apply` after a `plan` on a different machine.
+resource "local_file" "function_archive_for_upload" {
+  count = var.execution_type == "function" ? 1 : 0
+
+  filename        = "${path.module}/${var.job_name}-function.zip"
+  content_base64  = data.local_sensitive_file.function_archive_content[0].content_base64
+  file_permission = "0644"
+}
+
 # Upload function archive to storage bucket (only for Cloud Functions)
 # The object name includes the source code hash, ensuring:
 # 1. Cloud Function redeploys when source code changes (new hash = new object name)
@@ -64,9 +75,9 @@ data "local_sensitive_file" "function_archive_content" {
 resource "google_storage_bucket_object" "function_archive" {
   count = var.execution_type == "function" ? 1 : 0
 
-  name    = "${var.job_name}-function-${data.archive_file.function_archive[0].output_sha}.zip"
-  bucket  = google_storage_bucket.function_bucket[0].name
-  content = data.local_sensitive_file.function_archive_content[0].content
+  name   = "${var.job_name}-function-${data.archive_file.function_archive[0].output_sha}.zip"
+  bucket = google_storage_bucket.function_bucket[0].name
+  source = local_file.function_archive_for_upload[0].filename
 }
 
 # PubSub topic for triggering the Cloud Function (only created when execution_type is "function")