Bump [compat] entry: CategoricalArrays="1.0" - #61
Conversation
|
@ablaom in the ci tests we see |
|
Sorry, my bad. This PR needs:
@EssamWisam Let me ping you when this ready. |
|
Looks like document generation needs:
|
|
Okay, MLJ is also a doc dependency, and we cannot update the MLJ compat entry for CategoricalArrays before MLJTransforms. Documentation has a circular dependency. Note to self. Centralised, top-level documentation has its advantages. Otherwise, documentation needs to avoid depending on packages on which the package itself is a dependency. No matter. Failed doc generation does not get deployed. So plan merging, and tagging the doc problem as follow-up issue. |
|
@EssamWisam Ready for a review |
|
I found that Looks good to me and will merge. |
|
Thank you @EssamWisam. ❤️ |
Recall that CategoricalArrays 1.0 introduces new behaviour for
levels. The return value is aCategoricalArrayinstead of raw levels.As I am not familiar with the codebase for the newer encoders, I have simply replaced all calls
levelswithrawlevels, whererawlevelsmimics the old behaviour:rawlevels(A) = unwrap.(levels(A)).This PR is needed before important rollout of the CategoricalArrays="1.0" update can happen elsewhere in the MLJ ecosystem. In particular, MLJModels, needs this PR merged before it can do the update.