Merge pull request #22399 from Homebrew/cask-dry-run-dependencies

install: avoid cask dry-run keg reads

Author: MikeMcQuaid

Library/Homebrew/cask_dependent.rb

@@ -38,9 +38,11 @@ def full_name
     @cask.full_name
   end
 
-  sig { returns(T::Array[Dependency]) }
-  def runtime_dependencies
-    deps.flat_map { |dep| [dep, *dep.to_installed_formula.runtime_dependencies] }.uniq
+  sig { params(read_from_tab: T::Boolean, undeclared: T::Boolean).returns(T::Array[Dependency]) }
+  def runtime_dependencies(read_from_tab: true, undeclared: true)
+    deps.flat_map do |dep|
+      [dep, *dep.to_installed_formula.runtime_dependencies(read_from_tab:, undeclared:)]
+    end.uniq
   end
 
   sig { returns(T::Array[Dependency]) }

Library/Homebrew/install.rb

@@ -610,7 +610,7 @@ def print_dry_run_casks(casks, action: "install", skip_cask_deps: false, include
           end
           dep_names.concat(
             CaskDependent.new(cask)
-                         .runtime_dependencies
+                         .runtime_dependencies(read_from_tab: false, undeclared: false)
                          .reject(&:installed?)
                          .map(&:name),
           )

Library/Homebrew/test/cmd/install_spec.rb

@@ -127,10 +127,12 @@
   it "prompts when asking for casks with dependencies", :cask do
     cask = Cask::CaskLoader.load(cask_path("local-caffeine"))
     dependency = instance_double(Dependency, installed?: false, name: "unar")
+    cask_dependent = instance_double(CaskDependent)
 
     allow(CaskDependent).to receive(:new)
       .with(cask)
-      .and_return(instance_double(CaskDependent, runtime_dependencies: [dependency]))
+      .and_return(cask_dependent)
+    allow(cask_dependent).to receive(:runtime_dependencies).and_return([dependency])
     expect(Homebrew::Install).to receive(:ask_input).with(action: "installation")
 
     expect do
@@ -143,6 +145,28 @@
     EOS
   end
 
+  it "does not read installed formula metadata for cask dependency dry-run plans", :cask do
+    cask = Cask::CaskLoader.load(cask_path("local-caffeine"))
+    dependency = instance_double(Dependency, installed?: false, name: "ripgrep")
+    cask_dependent = instance_double(CaskDependent)
+
+    allow(CaskDependent).to receive(:new)
+      .with(cask)
+      .and_return(cask_dependent)
+    expect(cask_dependent).to receive(:runtime_dependencies)
+      .with(read_from_tab: false, undeclared: false)
+      .and_return([dependency])
+
+    expect do
+      Homebrew::Install.ask_casks([cask], prompt: false)
+    end.to output(<<~EOS).to_stdout
+      ==> Would install 1 cask:
+      local-caffeine
+      ==> Would install 1 dependency for local-caffeine:
+      ripgrep
+    EOS
+  end
+
   it "prompts when asking for casks with cask dependencies", :cask do
     cask = Cask::CaskLoader.load(cask_path("with-depends-on-cask"))