rename /selfAssign to distinguish from other judge adding endpoint

Author: crystaltine

common/src/types.ts

@@ -90,10 +90,4 @@ export type AutoPopulatedDoc<PopulatedType> = PopulatedType & { _id: mongoose.Re
  * for managing permissions.
  */
 export type AbilityAction =
-  | "read"
-  | "create"
-  | "update"
-  | "delete"
-  | "manage"
-  | "aggregate"
-  | "refer";
+  "read" | "create" | "update" | "delete" | "manage" | "aggregate" | "refer" | "selfAssign";

services/expo/src/permission.ts

@@ -23,7 +23,7 @@ export const addAbilities = (): RequestHandler => (req, res, next) => {
   if (req.user.roles.admin || req.user.roles.member) {
     can("manage", "Company");
     can("manage", "Team");
-    can("update", "CategoryGroup");
+    can("selfAssign", "CategoryGroup");
   }
 
   can("manage", "Profile", { userId: req.user.uid });

services/expo/src/routes/categorygroups.ts

@@ -163,6 +163,7 @@ categoryGroupRoutes.route("/:id").patch(
   })
 );
 
+/** (admin only), add a given judge to a given categoryGroup */
 categoryGroupRoutes.route("/:id/judges").post(
   isAdmin,
   asyncHandler(async (req, res) => {
@@ -212,8 +213,13 @@ categoryGroupRoutes.route("/:id").delete(
   })
 );
 
-categoryGroupRoutes.route("/:id/add").post(
-  checkAbility("update", "CategoryGroup"),
+/**
+ * Self assign the current user to a given category group.
+ * diff from the other judge assigner is that this one's open to
+ * hexlabs members, but only handles self-assigning.
+ */
+categoryGroupRoutes.route("/:id/selfAssign").post(
+  checkAbility("selfAssign", "CategoryGroup"),
   asyncHandler(async (req, res) => {
     const categoryGroupId = Number(req.params.id);
     const userId = req.user?.uid;