Repository navigation
Commit 6796da4
committed
fix(semantic): a replayed repair needs corroboration in the frame it lands on
A repair learned on one dataset was replayed onto another whose column meant
something different, and applied automatically:
A: segment = M/F -> learns M -> male
B: segment = S/M/L -> becomes S/male/L/male (status=automatic,
human_review=False,
confidence 0.95)
Clothing sizes silently rewritten as genders.
The conflict machinery already existed and worked: _conflict_proposal turns a
deterministic-vs-memory clash into a high-risk unsafe_ambiguous record that is
never auto-applied. But it only fires on disagreement. On B the
CategorySynonymExpert correctly abstains -- the column is not gender-like --
and an abstention is not a disagreement, so _merge_proposals passed the
replayed repair through carrying the full confidence it earned elsewhere:
det_list = det_by_key.get(key)
if not det_list:
merged.append(mem_p) # no deterministic proposal at all
continue
Every other branch was careful. Only total silence had no handling, and silence
is exactly what happens when the evidence behind a learned repair is absent.
The stored column_signature/value_signature would not have caught it: both
columns profile as role="categorical", semantic_type=None, free_text=False.
A replayed repair whose issue type is context-dependent -- category_synonym,
boolean_synonym, reference_value, where the same token means different things
in different columns -- is now demoted to a review-required suggestion when
nothing in this frame corroborates it. Context-free repairs (encoding_repair,
format_alignment, numeric_format and the rest) are untouched: they mean the
same thing in every column, so demoting them would cost the feature without
buying any safety.
sizes + gender memory S/M/L kept, suggested / risk=high / human_review
genders + gender memory still auto-applied -- the feature still works
Provenance survives the demotion, which matters more for a held decision than
an applied one: memory_influenced, model_id ending :memory, backend="memory",
evidence kinds memory_replay and a new memory_uncorroborated note carrying the
reason.
4 of the 5 new tests fail on main; the one that passes is the
feature-still-works control.
This also flips five tests that #481 pinned as current behaviour when it found
the defect. They were tripwires for the fix and the fix tripped them; each now
asserts the repaired behaviour with its history kept in the docstring. Two
findings in that file stay pinned because they remain true: freshdata_version
is written and never read, and the SQLite store overwrites on a dataset_id
collision.
Full suite 7098 passed / 0 failed, coverage 94.94%; ruff clean repo-wide.1 parent b363c39 commit 6796da4
3 files changed
Lines changed: 224 additions & 36 deletions
File tree
- src/freshdata/semantic
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
72 | 115 | | |
73 | 116 | | |
74 | 117 | | |
| |||
106 | 149 | | |
107 | 150 | | |
108 | 151 | | |
109 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
110 | 157 | | |
111 | 158 | | |
112 | 159 | | |
| |||
128 | 175 | | |
129 | 176 | | |
130 | 177 | | |
131 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
132 | 189 | | |
133 | 190 | | |
134 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
90 | | - | |
91 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
92 | 96 | | |
93 | 97 | | |
94 | 98 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
102 | 111 | | |
103 | 112 | | |
104 | 113 | | |
| |||
109 | 118 | | |
110 | 119 | | |
111 | 120 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
116 | 125 | | |
117 | 126 | | |
118 | 127 | | |
119 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
120 | 131 | | |
121 | 132 | | |
122 | 133 | | |
| |||
179 | 190 | | |
180 | 191 | | |
181 | 192 | | |
182 | | - | |
| 193 | + | |
183 | 194 | | |
184 | 195 | | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
189 | 203 | | |
190 | | - | |
| 204 | + | |
191 | 205 | | |
192 | 206 | | |
193 | 207 | | |
194 | | - | |
| 208 | + | |
| 209 | + | |
195 | 210 | | |
196 | 211 | | |
197 | 212 | | |
| |||
254 | 269 | | |
255 | 270 | | |
256 | 271 | | |
257 | | - | |
| 272 | + | |
258 | 273 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
263 | 278 | | |
264 | 279 | | |
265 | | - | |
266 | | - | |
267 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
268 | 286 | | |
269 | 287 | | |
270 | | - | |
| 288 | + | |
| 289 | + | |
271 | 290 | | |
272 | 291 | | |
273 | 292 | | |
| |||
390 | 409 | | |
391 | 410 | | |
392 | 411 | | |
393 | | - | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
394 | 416 | | |
395 | 417 | | |
396 | 418 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
0 commit comments