Skip to content

Commit 56eb190

Browse files
committed
DB is strict #12569
1 parent 56ee849 commit 56eb190

6 files changed

Lines changed: 39 additions & 14 deletions

File tree

‎composer.lock‎

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎config/autoload/doctrine.global.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
'password' => '',
1515
'port' => 3306,
1616
'driverOptions' => [
17-
PDO::MYSQL_ATTR_INIT_COMMAND => 'SET NAMES utf8mb4',
17+
PDO::MYSQL_ATTR_INIT_COMMAND => "SET NAMES utf8mb4; SET sql_mode = 'STRICT_TRANS_TABLES';",
1818
],
1919
'defaultTableOptions' => [
2020
'charset' => 'utf8mb4',
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace Application\Migration;
6+
7+
use Doctrine\DBAL\Schema\Schema;
8+
use Doctrine\Migrations\AbstractMigration;
9+
10+
class Version20260508114201 extends AbstractMigration
11+
{
12+
public function up(Schema $schema): void
13+
{
14+
$this->addSql('ALTER TABLE country CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
15+
$this->addSql('ALTER TABLE event CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
16+
$this->addSql('ALTER TABLE facilitator_document CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
17+
$this->addSql('ALTER TABLE log CHANGE request request LONGTEXT DEFAULT \'\' NOT NULL');
18+
$this->addSql('ALTER TABLE news CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
19+
$this->addSql('ALTER TABLE order_line CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
20+
$this->addSql('ALTER TABLE product CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
21+
$this->addSql('ALTER TABLE product_tag CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
22+
$this->addSql('ALTER TABLE session CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
23+
$this->addSql('ALTER TABLE subscription CHANGE name name VARCHAR(191) DEFAULT \'\' NOT NULL');
24+
}
25+
}

‎server/Application/Service/Importer.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,8 +388,8 @@ private function readSubscriptionType(string $subscriptionType): ?ProductType
388388
private function updateUser(...$args): void
389389
{
390390
$params = $args;
391-
$params[] = false; // web_temporary_access
392-
$params[] = false; // should_delete
391+
$params[] = 0; // web_temporary_access
392+
$params[] = 0; // should_delete
393393
$params[] = ''; // password
394394
$params[] = $this->currentUser;
395395

@@ -447,7 +447,7 @@ private function updateAllUsers(): void
447447
private function updateOrganization(...$args): void
448448
{
449449
$params = $args;
450-
$params[] = false; // should_delete
450+
$params[] = 0; // should_delete
451451
$params[] = $this->currentUser;
452452

453453
array_push($this->organizationsParams, ...$params);

‎tests/data/query/anonymous-can-confirm-registration.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ function (Doctrine\DBAL\Connection $connection): void {
3030
'user',
3131
[
3232
'token' => '09876543210987654321098765432109',
33-
'token_creation_date' => Cake\Chronos\Chronos::now()->subMinutes(1)->toIso8601String(),
33+
'token_creation_date' => Cake\Chronos\Chronos::now()->subMinutes(1),
3434
],
3535
[
3636
'email' => 'administrator@example.com',
37-
]
37+
],
3838
);
3939
},
4040
];

‎tests/data/query/anonymous-can-update-password-for-administrator.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ function (Doctrine\DBAL\Connection $connection): void {
1919
'user',
2020
[
2121
'token' => '09876543210987654321098765432109',
22-
'token_creation_date' => Cake\Chronos\Chronos::now()->subMinutes(1)->toIso8601String(),
22+
'token_creation_date' => Cake\Chronos\Chronos::now()->subMinutes(1),
2323
],
2424
[
2525
'email' => 'administrator@example.com',
26-
]
26+
],
2727
);
2828
},
2929
];

0 commit comments

Comments
 (0)