feat: switch grisu2 float-to-string algorithm to Xiang JunBo's xjb algorithm#3025
Draft
JairusSW wants to merge 3 commits into
Draft
feat: switch grisu2 float-to-string algorithm to Xiang JunBo's xjb algorithm#3025JairusSW wants to merge 3 commits into
JairusSW wants to merge 3 commits into
Conversation
Signed-off-by: Jairus Tanaka <me@jairus.dev>
Signed-off-by: Jairus Tanaka <me@jairus.dev>
Signed-off-by: Jairus Tanaka <me@jairus.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3012.
Changes proposed in this pull request:
⯈ Switch to xjb-as which is an improvement over zmij-as
⯈ Comply to the ECMA262 Specification with the exception of a trailing
.0It's good quality stuff though, and I'm quite confident in that.
Here's some performance notes. xjb-as/README.md has more extensive notes and stuff. These benches are taken on an AMD 7800x3D.
The resulting
.wasmsizes are actually fairly small. Multiple tables are chosen from depending onASC_SHRINK_SIZE.--runtime stub, SIMD)-O3-Ozdtoa(f64)ftoa(f32)